Add JSON profiling support for HTTP stats #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @tobilg, thanks for the PR, just a heads up that it will take a bit longer to get a proper review in, but we'll be back to this. |
Author
|
@carlopi yeah, no worries. I‘ll try to split my large PR to the main repo first. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds structured JSON profiling output for HTTPFS statistics, complementing the existing text-based profiling.
This is in preparation of another PR on DuckDB itself that will add comprehensive NDJSON logging and profiling support eventually. I will link the DuckDB PR once it's ready @carlopi. Thanks!
Changes
WriteProfilingInformationToJSON()method toHTTPStateclasstotal_bytes_received,total_bytes_sent,head_count,get_count,put_count,post_count,delete_countForward Compatibility
The method is implemented without
overridefor forward compatibility. When DuckDB addsWriteProfilingInformationToJSON()toClientContextState, this implementation will automatically override it. Addingoverrideat that time is recommended for compile-time safety.